Skip to content

introduce combination of "brackets" and "numbered" option on slices #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sGy1980de
Copy link

This PR introduces the combination of "brackets" and "numbered" option on slices to provide indexed brackets in the URL.

Given

p := struct{
   Values []string `url:"key,brackets,numbered"`
}{
  Values []string{"value0", "value1"},
}

Currently this combination is possible but would lead to something like
key[]0=value0&key[]1=value1

This behavior will be changed to something similar like this PHP method would create:
https://www.php.net/manual/en/function.http-build-query.php

The upper example would look like this:
key[0]=value0&key[1]=value1

While there is nothing wrong with the brackets only syntax, some APIs, e.g. LinkedIn Ads API simply insist on the indexed brackets syntax. I'm aware this can be created with maps, but still this might be a useful extension.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sGy1980de
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants