make Geneve implement DecodingLayer #1202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, the Geneve layer would not fully implement
DecodingLayer. This would prevent Geneve to be added as a DecodingLayer
to gopacket.NewDecodingLayerParser():
cannot use &Geneve{} (value of type *Geneve) as gopacket.DecodingLayer value in argument to gopacket.NewDecodingLayerParser: *Geneve does not implement gopacket.DecodingLayer (missing method CanDecode)
This patch implements (*Geneve).CanDecode() and a test to ensure Geneve
can be used as a DecodingLayer.
Signed-off-by: Alexandre Perrin <[email protected]>
|
Didn't see there is already a PR open for this bug #1172 |
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Feb 14, 2025
Waiting on google/gopacket#1202. If it's not merged and released before this PR land then we might need to comment out Geneve parsing in Hubble. Signed-off-by: Alexandre Perrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the
Genevelayer would not fully implementDecodingLayer. This would preventGeneveto be added as aDecodingLayertogopacket.NewDecodingLayerParser():This patch implements
(*Geneve).CanDecode()and a test to ensureGenevecan be used as aDecodingLayer.