Adapting the TfheRustBool dialect to pass the packed api + update cggi to tfhe rust bool conversion pass #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WoutLegiest - can you consider adding the CMake files for the new dialect and the transform pass ? It should be straight forward |
j2kun
requested changes
Aug 2, 2024
WoutLegiest
added
the
pull_ready
j2kun
reviewed
Aug 8, 2024
|
adding a PR WoutLegiest#1 into your branch to enable CMake build in order |
WoutLegiest
force-pushed
the
dev-conv2
branch
3 times, most recently
from
698dcfb
to
fb44d32
Compare
asraa
reviewed
Aug 20, 2024
|
Sorry about this! I think this just needed a rebase before merging |
|
Going to rebase this one myself! |
asraa
force-pushed
the
dev-conv2
branch
3 times, most recently
from
9cf3a93
to
b7d5aab
Compare
asraa
approved these changes
Oct 12, 2024
…s update Adding the (common) enum attribute to model Boolean gates Co-authored-by: Wouter Legiest <[email protected]> Co-authored-by: Asra Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work of #838