Skip to content

Conversation

@sotetsuk
Copy link

@sotetsuk sotetsuk commented Jan 6, 2024

Same PR as #126. Resolved CLA issue.


Hi, jaxonnxruntime is awesome! I truly believe it is incredibly useful and a great asset to the community.

In this PR, I added a version 9 of Flatten because I got the following error when I run an ONNX model in jaxonnxruntime.

    raise NotImplementedError(
NotImplementedError: Flatten version 9 is not implemented. Only have those versions: ['version_1', 'version_11', 'version_13'].

It looks like there are version 1, 9, 11 and 13 in ONNX but currently jaxonnxruntime only has 1, 11 and 13.
Note that this model works well with (non-jax) onnxruntime and I found it also works well with jaxonnxruntime with this modification.

I read the contributing.md. As this PR is not for a new op but for a new version of existing ops, I suppose I do not need to add a new test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant