Skip to content

When unmarshaling, check the payload's type even if no ID is included #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

When unmarshaling, check the payload's type even if no ID is included #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,6 @@ func unmarshalNode(data *Node, model reflect.Value, included *map[string]*Node)
}

if annotation == annotationPrimary {
if data.ID == "" {
continue
}

// Check the JSON API Type
if data.Type != args[1] {
er = fmt.Errorf(
Expand All @@ -168,6 +164,10 @@ func unmarshalNode(data *Node, model reflect.Value, included *map[string]*Node)
break
}

if data.ID == "" {
continue
}

// ID will have to be transmitted as astring per the JSON API spec
v := reflect.ValueOf(data.ID)

Expand Down