Skip to content

Add true and false as operands of is and is not #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochafik merged 3 commits into from
May 15, 2025
Merged

Add true and false as operands of is and is not #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51a1db5
feat: add `true` and `false` as operands of `is` and `is not`
grf53 May 1, 2025
964dc69
test: add tests for `is true/false` and `is not true/false`
grf53 May 1, 2025
09f8cb4
Merge branch 'main' into is-boolean-value
ochafik May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/minja/minja.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1306,6 +1306,8 @@ class BinaryOpExpr : public Expression {
if (name == "iterable") return l.is_iterable();
if (name == "sequence") return l.is_array();
if (name == "defined") return !l.is_null();
if (name == "true") return l.to_bool();
if (name == "false") return !l.to_bool();
throw std::runtime_error("Unknown type for 'is' operator: " + name);
};
auto value = eval();
Expand Down
12 changes: 12 additions & 0 deletions tests/test-syntax.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,18 @@ TEST(SyntaxTest, SimpleCases) {
EXPECT_EQ(
"False",
render(R"({% set foo = true %}{{ not foo is defined }})", {}, {}));
EXPECT_EQ(
"True",
render(R"({% set foo = true %}{{ foo is true }})", {}, {}));
EXPECT_EQ(
"False",
render(R"({% set foo = true %}{{ foo is false }})", {}, {}));
EXPECT_EQ(
"True",
render(R"({% set foo = false %}{{ foo is not true }})", {}, {}));
EXPECT_EQ(
"False",
render(R"({% set foo = false %}{{ foo is not false }})", {}, {}));
EXPECT_EQ(
R"({"a": "b"})",
render(R"({{ {"a": "b"} | tojson }})", {}, {}));
Expand Down