Skip to content

Support llava-hf/llava-1.5-7b-hf with .upper() string method #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochafik merged 3 commits into from
Aug 7, 2025
Merged

Support llava-hf/llava-1.5-7b-hf with .upper() string method #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
657ed38
Support .upper() and .lower() string methods
yatarkan Aug 7, 2025
7ad4089
Add syntax tests for upper and lower methods
yatarkan Aug 7, 2025
295676f
Add llava-hf/llava-1.5-7b-hf to supported models
yatarkan Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions include/minja/minja.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,6 +1541,16 @@ class MethodCallExpr : public Expression {
} else if (method->get_name() == "capitalize") {
vargs.expectArgs("capitalize method", {0, 0}, {0, 0});
return Value(capitalize(str));
} else if (method->get_name() == "upper") {
vargs.expectArgs("upper method", {0, 0}, {0, 0});
auto result = str;
std::transform(result.begin(), result.end(), result.begin(), ::toupper);
return Value(result);
} else if (method->get_name() == "lower") {
vargs.expectArgs("lower method", {0, 0}, {0, 0});
auto result = str;
std::transform(result.begin(), result.end(), result.begin(), ::tolower);
return Value(result);
} else if (method->get_name() == "endswith") {
vargs.expectArgs("endswith method", {1, 1}, {0, 0});
auto suffix = vargs.args[0].get<std::string>();
Expand Down
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ set(MODEL_IDS
knifeayumu/Cydonia-v1.3-Magnum-v4-22B
langgptai/qwen1.5-7b-chat-sa-v0.1
LatitudeGames/Wayfarer-12B
llava-hf/llava-1.5-7b-hf
LGAI-EXAONE/EXAONE-3.5-2.4B-Instruct
LGAI-EXAONE/EXAONE-3.5-7.8B-Instruct
lightblue/DeepSeek-R1-Distill-Qwen-7B-Japanese
Expand Down
8 changes: 8 additions & 0 deletions tests/test-syntax.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ TEST(SyntaxTest, SimpleCases) {
EXPECT_EQ("abcXYZabcXYZabc",
render("{{ 'abcXYZabcXYZabc'.replace('def', 'ok') }}", {}, {}));

EXPECT_EQ("HELLO WORLD", render("{{ 'hello world'.upper() }}", {}, {}));
EXPECT_EQ("MIXED", render("{{ 'MiXeD'.upper() }}", {}, {}));
EXPECT_EQ("", render("{{ ''.upper() }}", {}, {}));

EXPECT_EQ("hello world", render("{{ 'HELLO WORLD'.lower() }}", {}, {}));
EXPECT_EQ("mixed", render("{{ 'MiXeD'.lower() }}", {}, {}));
EXPECT_EQ("", render("{{ ''.lower() }}", {}, {}));

EXPECT_EQ(
"ok",
render("{# Hey\nHo #}{#- Multiline...\nComments! -#}{{ 'ok' }}{# yo #}", {}, {}));
Expand Down
Loading