Skip to content

Symbols are too prioritized than normal candidates #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Mar 20, 2025

Description

The current priorty of dice symbols is too high. They are higher than fullwidth digits.
They should be lower than fullwidth and halfwidth digits at least.

Issue IDs

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: [e.g. Windows 11, macOS 13.1, etc] Windows 11
  • Steps:
    1. input a fullwidth digit (e.g. 1)
    2. compose
    3. Confirm the corresponding dice symbol (e.g. ⚀) is below the halfwidth and fullwidth digits

Additional context

Before:

image

After:

image

Note

Not ideal; I would like to lower the priority of it even more if possible.

@hiroyuki-komatsu
Copy link
Collaborator

Thank you for your PR.

I understand the issue, but I'm afraid this change relies on some unexpected behavior.
We might need to change the logic around SymbolRewriter instead.

It'd be great if you are willing to file an issue as "Symbols are too prioritized than normal candidates".
Best,

@tats-u tats-u changed the title Lower the priority of dice symbols Symbols are too prioritized than normal candidates Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants