Set --enable_runfiles for Windows Bazel builds
#1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a preparation to make unit tests run with Bazel on Windows (google#1223), this commit adds '--enable_runfiles' to build/test commands on Windows. Otherwise, some tests fail due to missing generated files.
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a preparation to make unit tests run with Bazel on Windows (#1223), this commit adds
--enable_runfilesto build/test commands on Windows. Otherwise, some tests fail due to missing generated files.Issue IDs
bazelisk test ...run and pass on Windows #1223Steps to test new behaviors (if any)
bazelisk test //win32/base:text_icon_test --config oss_windows -c dbg --build_tests_only