Fix counter_suffix.data corruption on Windows Bazel build
#1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many dictionary-related scripts assume dictionary files including generated ones have LF as the line ending. Without this change, 'counter_suffix.data' will not be created as expected only on Windows Bazel build, which is why 'NumberRewriter::RewriteOneSegment' does not work here. Closes google#1251.
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many dictionary-related scripts assume dictionary files including generated ones have LF as the line ending. Without this change,
counter_suffix.datawill not be created as expected only on Windows Bazel build, which is whyNumberRewriter::RewriteOneSegmentdoes not work here.Closes #1251.
Issue IDs
Steps to test new behaviors (if any)
Mozc64.msiwith Bazel and install it.