Make update_deps.py compatible with Python 3.9
#1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up to my previous commit [1], where 'update_deps.py' is updated to also deploy MSYS2 for Windows to automate build environment setup for Windows (google#1079). The issue is that the above commit introduced the dependency on 'onexc' parameter in 'shutil.rmtree', which is only available in Python 3.12 and later, while we still would like to support Python 3.9.6 that is installed as part of Xcode Command Line Tools. To make 'update_deps.py' compatible with Python 3.9.6 again, let's use 'onexc' when and only when it is actually available. [1]: 837d4da
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up to my previous commit (837d4da), where
update_deps.pyis updated to also deploy MSYS2 for Windows to automate build environment setup for Windows.The issue is that the above commit introduced the dependency on
onexcparameter inshutil.rmtree, which is only available in Python 3.12 and later, while we still would like to support Python 3.9.6 that is installed as part of Xcode Command Line Tools.To make
update_deps.pycompatible with Python 3.9.6 again, let's useonexcwhen and only when it is actually available.Issue IDs
Steps to test new behaviors (if any)
python3 build_tools/update_deps.pysucceeds.