Skip to content

Add Registry Lock password reset on front end#2785

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:passwordUi
Jul 28, 2025
Merged

Add Registry Lock password reset on front end#2785
gbrodman merged 1 commit into
google:masterfrom
gbrodman:passwordUi

Conversation

@gbrodman

@gbrodman gbrodman commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

This is only enabled for admins, for now at least. It sends an email to the registry lock email address to reset it.

tested on alpha, got the "would have sent email" log line


This change is Reviewable

@gbrodman
gbrodman force-pushed the passwordUi branch 2 times, most recently from b4e749e to a754752 Compare July 24, 2025 15:40
@gbrodman
gbrodman requested a review from ptkach July 24, 2025 18:27

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 15 files at r1, all commit messages.
Reviewable status: 14 of 15 files reviewed, 1 unresolved discussion


console-webapp/src/styles.scss line 50 at r1 (raw file):

    min-height: 48px;
    padding: 10px 0;
    --list-item-title-width: 160px;

This will affect all lists. I'd suggest a local override where it's needed instead unless all lists is what you're aiming for

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 14 of 15 files reviewed, 1 unresolved discussion (waiting on @ptkach)


console-webapp/src/styles.scss line 50 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

This will affect all lists. I'd suggest a local override where it's needed instead unless all lists is what you're aiming for

Done.

This is only enabled for admins, for now at least. It sends an email to
the registry lock email address to reset it.

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 15 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gbrodman)

@gbrodman
gbrodman added this pull request to the merge queue Jul 28, 2025
Merged via the queue into google:master with commit 9f191e9 Jul 28, 2025
9 checks passed
@gbrodman
gbrodman deleted the passwordUi branch July 28, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants