Update resource allocation for proxy deployment#2794
Merged
Conversation
Collaborator
Author
|
Tested in crash |
CydeWeys
reviewed
Aug 6, 2025
CydeWeys
left a comment
CydeWeys
left a comment
Member
There was a problem hiding this comment.
Can you add more description of what the changes are and what motivates them in the commit description?
Reviewable status: 0 of 4 files reviewed, all discussions resolved
Missing resource requests as well as metrics for when to evict resource produced situation when under load k8s struggled to assign pods. This adds default resource requirements based on 2 weeks metrics and instructions when resource should be evicted.
ptkach
commented
Aug 6, 2025
ptkach
left a comment
ptkach
left a comment
Collaborator
Author
There was a problem hiding this comment.
Done
Reviewable status: 0 of 4 files reviewed, all discussions resolved
CydeWeys
approved these changes
Aug 7, 2025
CydeWeys
left a comment
CydeWeys
left a comment
Member
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing resource requests as well as metrics for when to evict pods
produced situation when under load k8s struggled to assign pods. This
adds default resource requirements based on 2 weeks metrics and
instructions when pods should be evicted.
Resolves b/435171505.
This change is