Chage run-time of DeleteExpiredDomainsAction#2801
Conversation
ptkach
left a comment
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion
core/src/main/java/google/registry/config/files/tasks/cloud-scheduler-tasks-sandbox.xml line 116 at r1 (raw file):
autorenew end date. </description> <schedule>30 2 * * *</schedule>
Great idea! I checked and it looks like this task usually takes under a minute. Given that I think it'd make sense to move it even closer to expandBillingRecurrences, maybe 2.45 ? And I'd live a comment in both places to hint that timing is related
We probably want this to run before the billing recurrence expansion pipeline just in case there are any domains that should be deleted before their billing recurrence gets expanded.
gbrodman
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @ptkach)
core/src/main/java/google/registry/config/files/tasks/cloud-scheduler-tasks-sandbox.xml line 116 at r1 (raw file):
Previously, ptkach (Pavlo Tkach) wrote…
Great idea! I checked and it looks like this task usually takes under a minute. Given that I think it'd make sense to move it even closer to
expandBillingRecurrences, maybe 2.45 ? And I'd live a comment in both places to hint that timing is related
Done.
ptkach
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)
ptkach
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
We probably want this to run before the billing recurrence expansion pipeline just in case there are any domains that should be deleted before their billing recurrence gets expanded.
This change is