Include internal registrars in the console#2821
Conversation
ptkach
left a comment
There was a problem hiding this comment.
@ptkach reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)
core/src/main/java/google/registry/ui/server/console/RegistrarsAction.java line 57 at r1 (raw file):
private static final int PASSCODE_LENGTH = 5; private static final ImmutableSet<Registrar.Type> allowedRegistrarTypes = ImmutableSet.of(Registrar.Type.INTERNAL, Registrar.Type.REAL, Registrar.Type.OTE);
I think we should have 2 lists and user them per-user - one list for admins, another for users. That would make it safer
This allows us to also check / modify the CharlestonRoad registrar in the console, and also allows us to test actions (like password reset) using that registrar in the prod environment.
gbrodman
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ptkach)
core/src/main/java/google/registry/ui/server/console/RegistrarsAction.java line 57 at r1 (raw file):
Previously, ptkach (Pavlo Tkach) wrote…
I think we should have 2 lists and user them per-user - one list for admins, another for users. That would make it safer
sure that makes sense
d523795 to
105ee9f
Compare
ptkach
left a comment
There was a problem hiding this comment.
@ptkach reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)
This allows us to also check / modify the CharlestonRoad registrar in the console, and also allows us to test actions (like password reset) using that registrar in the prod environment.
This change is