Skip to content

Include internal registrars in the console#2821

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:internalRegistrarConsole
Sep 5, 2025
Merged

Include internal registrars in the console#2821
gbrodman merged 1 commit into
google:masterfrom
gbrodman:internalRegistrarConsole

Conversation

@gbrodman

@gbrodman gbrodman commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

This allows us to also check / modify the CharlestonRoad registrar in the console, and also allows us to test actions (like password reset) using that registrar in the prod environment.


This change is Reviewable

@gbrodman
gbrodman requested a review from ptkach September 5, 2025 18:23

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptkach reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)


core/src/main/java/google/registry/ui/server/console/RegistrarsAction.java line 57 at r1 (raw file):

  private static final int PASSCODE_LENGTH = 5;
  private static final ImmutableSet<Registrar.Type> allowedRegistrarTypes =
      ImmutableSet.of(Registrar.Type.INTERNAL, Registrar.Type.REAL, Registrar.Type.OTE);

I think we should have 2 lists and user them per-user - one list for admins, another for users. That would make it safer

This allows us to also check / modify the CharlestonRoad registrar in
the console, and also allows us to test actions (like password reset)
using that registrar in the prod environment.

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ptkach)


core/src/main/java/google/registry/ui/server/console/RegistrarsAction.java line 57 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

I think we should have 2 lists and user them per-user - one list for admins, another for users. That would make it safer

sure that makes sense

@gbrodman
gbrodman force-pushed the internalRegistrarConsole branch from d523795 to 105ee9f Compare September 5, 2025 18:47

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptkach reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)

@gbrodman
gbrodman added this pull request to the merge queue Sep 5, 2025
Merged via the queue into google:master with commit ee5a2d3 Sep 5, 2025
8 of 9 checks passed
@gbrodman
gbrodman deleted the internalRegistrarConsole branch September 5, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants