Verify existence of TLDs and registrars for tokens

[gbrodman]

Just in case someone makes a typo when running the commands

---

This change is 

[jicelhay]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions

---

core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java line 336 at r1 (raw file):

  static void verifyAllRegistrarIdsExist(@Nullable List<String> allowedClientIds) {
    if (isNullOrEmpty(allowedClientIds)) {

I think it's worth adding a comment mentioning that null/empty here translates to token valid for all clients.

---

core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java line 352 at r1 (raw file):

  static void verifyAllTldsExist(@Nullable List<String> allowedTlds) {
    if (isNullOrEmpty(allowedTlds)) {

Same type of comment here.

[gbrodman]

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @jicelhay)

---

core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java line 336 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

I think it's worth adding a comment mentioning that null/empty here translates to token valid for all clients.

sure

---

core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java line 352 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

Same type of comment here.

sure

[jicelhay]

@jicelhay reviewed 1 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gbrodman)