Skip to content

Only load from ClaimsList once when filling the cache#2843

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:claimsList
Oct 9, 2025
Merged

Only load from ClaimsList once when filling the cache#2843
gbrodman merged 1 commit into
google:masterfrom
gbrodman:claimsList

Conversation

@gbrodman

@gbrodman gbrodman commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@gbrodman
gbrodman requested a review from weiminyu October 9, 2025 15:35

@weiminyu weiminyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


core/src/main/java/google/registry/model/tmch/ClaimsListDao.java line 82 at r1 (raw file):

    return tm().reTransact(
            () ->
                tm().query("FROM ClaimsList ORDER BY revisionId DESC LIMIT 1", ClaimsList.class)

Do we need this? I think the setMaxResults below will add this.

Code quote:

LIMIT 1

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @weiminyu)


core/src/main/java/google/registry/model/tmch/ClaimsListDao.java line 82 at r1 (raw file):

Previously, weiminyu (Weimin Yu) wrote…

Do we need this? I think the setMaxResults below will add this.

Done.

@weiminyu weiminyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gbrodman)

@gbrodman
gbrodman added this pull request to the merge queue Oct 9, 2025
Merged via the queue into google:master with commit 8c96940 Oct 9, 2025
9 checks passed
@gbrodman
gbrodman deleted the claimsList branch October 9, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants