Only load from ClaimsList once when filling the cache#2843
Conversation
weiminyu
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
core/src/main/java/google/registry/model/tmch/ClaimsListDao.java line 82 at r1 (raw file):
return tm().reTransact( () -> tm().query("FROM ClaimsList ORDER BY revisionId DESC LIMIT 1", ClaimsList.class)
Do we need this? I think the setMaxResults below will add this.
Code quote:
LIMIT 1
gbrodman
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @weiminyu)
core/src/main/java/google/registry/model/tmch/ClaimsListDao.java line 82 at r1 (raw file):
Previously, weiminyu (Weimin Yu) wrote…
Do we need this? I think the
setMaxResultsbelow will add this.
Done.
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
This change is