Skip to content

Only attempt to load a single name in reservation checking#2844

Closed
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:reservedEntries
Closed

Only attempt to load a single name in reservation checking#2844
gbrodman wants to merge 1 commit into
google:masterfrom
gbrodman:reservedEntries

Conversation

@gbrodman

@gbrodman gbrodman commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

We don't need to load the whole list if we're only checking one name during something like a domain create.


This change is Reviewable

We don't need to load the whole list if we're only checking one name
during something like a domain create.
@CydeWeys

CydeWeys commented Oct 9, 2025

Copy link
Copy Markdown
Member

This might reduce performance? The current behavior is that the reserved list is loaded from the DB and then cached for an hour. (Reserved lists aren't that large, so loading them in their entirety and caching them is doable.)

This changes it to always loading every single entry in a reserved list individually, and not caching them?

@gbrodman

gbrodman commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator Author

eh yeah that's why i didn't submit it for review yet, i was musing on making sure the cache works in the original version and seeing if this could still involve caching

@gbrodman

gbrodman commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator Author

eh yeah once per hour loading the whole thing is probably fine

@gbrodman gbrodman closed this Oct 9, 2025
@gbrodman
gbrodman deleted the reservedEntries branch October 9, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants