Only attempt to load a single name in reservation checking#2844
Closed
gbrodman wants to merge 1 commit into
Closed
Only attempt to load a single name in reservation checking#2844gbrodman wants to merge 1 commit into
gbrodman wants to merge 1 commit into
Conversation
gbrodman
force-pushed
the
reservedEntries
branch
from
October 9, 2025 15:41
f553037 to
07f96e5
Compare
We don't need to load the whole list if we're only checking one name during something like a domain create.
gbrodman
force-pushed
the
reservedEntries
branch
from
October 9, 2025 17:00
07f96e5 to
9b7315d
Compare
Member
|
This might reduce performance? The current behavior is that the reserved list is loaded from the DB and then cached for an hour. (Reserved lists aren't that large, so loading them in their entirety and caching them is doable.) This changes it to always loading every single entry in a reserved list individually, and not caching them? |
Collaborator
Author
|
eh yeah that's why i didn't submit it for review yet, i was musing on making sure the cache works in the original version and seeing if this could still involve caching |
Collaborator
Author
|
eh yeah once per hour loading the whole thing is probably fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to load the whole list if we're only checking one name during something like a domain create.
This change is