Refactor EppResourceUtils.loadByForeignKey() -> ForeignKeyUtils.loadResource()

[CydeWeys]

This doesn't make any underlying implementation details, and is mainly useful to reduce the number of diffs in PR #2852 (which does change implementation details) thus making that easier to review.

---

This change is 

[gbrodman]

@gbrodman reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @CydeWeys)

---

core/src/main/java/google/registry/model/EppResourceUtils.java line 132 at r1 (raw file):

  }

  static <T extends EppResource> Optional<T> loadByForeignKeyHelper(

this is kind of an odd halfway state, should we (in this PR) move this method and the two methods above (loadByForeignKeysByCacheIfEnabled and loadByForeignKeysByCache) to ForeignKeyUtils so that everything can live there?

[CydeWeys]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)

---

core/src/main/java/google/registry/model/EppResourceUtils.java line 132 at r1 (raw file):

Previously, gbrodman wrote…

this is kind of an odd halfway state, should we (in this PR) move this method and the two methods above (loadByForeignKeysByCacheIfEnabled and loadByForeignKeysByCache) to ForeignKeyUtils so that everything can live there?

I'm OK with odd halfway states so long as nothing breaks. I just wanted to make this PR simple, with one method refactor, and not include anything else you'd need to undo in the subsequent one.

[gbrodman]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys)

---

core/src/main/java/google/registry/model/EppResourceUtils.java line 132 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

I'm OK with odd halfway states so long as nothing breaks. I just wanted to make this PR simple, with one method refactor, and not include anything else you'd need to undo in the subsequent one.

eh fair, i think a large part of why the other PR is kinda big is that I was trying to avoid halfway states

[CydeWeys]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys)

---

core/src/main/java/google/registry/model/EppResourceUtils.java line 132 at r1 (raw file):

Previously, gbrodman wrote…

eh fair, i think a large part of why the other PR is kinda big is that I was trying to avoid halfway states

They're fine, just a part of doing http://go/small-cls . The halfway state shouldn't even last more than a day or two anyway.

[gbrodman]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys)