Fix remote cache prefixing by handling it all in the Jedis client#3035
Merged
Conversation
gbrodman
force-pushed
the
usePrefixInSyncAction
branch
from
May 6, 2026 21:20
5ab8d4c to
4aed1e9
Compare
Found this out while testing metrics. In hindsight, not the best idea to handle prefixing outside of the client itself. Instead, we'll enforce the prefixing closer to Valkey, all in one place.
gbrodman
force-pushed
the
usePrefixInSyncAction
branch
from
May 7, 2026 16:10
4aed1e9 to
1cc542c
Compare
gbrodman
changed the title
jicelhay
approved these changes
May 7, 2026
jicelhay
left a comment
jicelhay
left a comment
Collaborator
There was a problem hiding this comment.
@jicelhay reviewed 10 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this out while testing metrics. In hindsight, not the best idea to
handle prefixing outside of the client itself. Instead, we'll enforce
the prefixing closer to Valkey, all in one place.
This change is