Skip to content

Add a step to cloudbuild-nomulus CB job to create a release in Cloud Deploy - #3059

Merged
jicelhay merged 6 commits into
google:masterfrom
jicelhay:createrelease
May 26, 2026
Merged

Add a step to cloudbuild-nomulus CB job to create a release in Cloud Deploy#3059
jicelhay merged 6 commits into
google:masterfrom
jicelhay:createrelease

Conversation

@jicelhay

@jicelhay jicelhay commented May 21, 2026

Copy link
Copy Markdown
Collaborator

This is added as the last step of the current release jobs in Cloud Build. It stores the previously computed digest for nomulus to use when creating the release.

This is safe because:

  • I've verified the command manually and gave the service account cd permissions.
  • The pipeline only has crash target configured + it requires manual approval to start the deployment.
  • If CB fails for whatever reason, I have until monday to fix before it becomes a problem.

This change is Reviewable

@jicelhay
jicelhay requested a review from weiminyu May 21, 2026 21:33
@weiminyu

Copy link
Copy Markdown
Collaborator

release/cloudbuild-nomulus.yaml line 191 at r1 (raw file):

    echo "Tag Name: ${TAG_NAME}"
    echo "Project ID: ${PROJECT_ID}"
    

nit: trailing whitespaces. Three more below.

Code quote:

···

weiminyu
weiminyu previously approved these changes May 22, 2026

@weiminyu weiminyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jicelhay).

@jicelhay

Copy link
Copy Markdown
Collaborator Author

release/cloudbuild-nomulus.yaml line 191 at r1 (raw file):

Previously, weiminyu (Weimin Yu) wrote…

nit: trailing whitespaces. Three more below.

Done.

@weiminyu weiminyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jicelhay).

@jicelhay
jicelhay added this pull request to the merge queue May 26, 2026
Merged via the queue into google:master with commit 5fd6e6c May 26, 2026
15 checks passed
@jicelhay
jicelhay deleted the createrelease branch May 26, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants