Address technical debt and improve safety in domain flows and models - #3065
Merged
Conversation
weiminyu
approved these changes
May 27, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
CydeWeys
enabled auto-merge
May 27, 2026 18:35
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Addressed unhandled empty lists and swallowed exceptions in DomainFlowTmchUtils. - Improved null safety and immutability guarantees in Fee and LaunchPhase. - Applied defensive copying in FeeTransformResponseExtension. Note: This uses the forceEmptyToNull(nullToEmptyImmutableCopy(...)) pattern. This defensive copy ensures immutability, while forceEmptyToNull is required because JAXB will serialize an empty collection as an empty XML tag (which violates EPP XML schemas). Setting it to null ensures JAXB omits the tag entirely. - Corrected JAXB property suppression in FeeCheckResponseExtensionItemStdV1.
Added checks for: - Incorrect @nullable imports. - Unstatically imported utility methods (DateTimeUtils/CacheUtils). - Redundant transaction wrapping (tm().transact -> tm().reTransact). - Mutable collection instantiations (ArrayList/HashMap).
| content = file.read() | ||
| if expected_header not in content: | ||
| log_error(f"Missing or incorrect copyright year in {f}. Expected: {expected_header}") | ||
| except FileNotFoundError: |
Member
Author
|
PTAL, had to change a file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is