Skip to content

Forbid deprecated algorithms in DNSSEC data#3078

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:9904algorithm
Jun 16, 2026
Merged

Forbid deprecated algorithms in DNSSEC data#3078
gbrodman merged 1 commit into
google:masterfrom
gbrodman:9904algorithm

Conversation

@gbrodman

@gbrodman gbrodman commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This is similar to PR #3069 but for the algorithms themselves rather than the digest data. This forbids algorithms, that, according to RFC 9904, should not be used.


This change is Reviewable

@gbrodman
gbrodman requested a review from CydeWeys June 5, 2026 20:43
@gbrodman
gbrodman requested a review from ptkach June 10, 2026 15:49

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 1 comment.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on gbrodman and ptkach).


core/src/test/java/google/registry/flows/domain/DomainUpdateFlowTest.java line 992 at r1 (raw file):

    assertAboutEppExceptions().that(thrown).marshalsToXml();
  }

What happens if there is existing invalid algorithm DS data on a domain and you make an unrelated domain update? There should be a test for this.

This is similar to PR google#3069 but for the algorithms themselves rather
than the digest data. This forbids algorithms, that, according to RFC
9904, should not be used.

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 1 comment.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on CydeWeys and ptkach).


core/src/test/java/google/registry/flows/domain/DomainUpdateFlowTest.java line 992 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

What happens if there is existing invalid algorithm DS data on a domain and you make an unrelated domain update? There should be a test for this.

sure -- we can do the same thing that we did for contacts and forbid any update flows if we have "bad" dsdata

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 1 comment.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on gbrodman and ptkach).


core/src/test/java/google/registry/flows/domain/DomainUpdateFlowTest.java line 992 at r1 (raw file):

Previously, gbrodman wrote…

sure -- we can do the same thing that we did for contacts and forbid any update flows if we have "bad" dsdata

Is that what we actually want to do though, or is that going to cause more customer inquiries? What's the overall migration/messaging strategy on this?

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 1 comment.
Reviewable status: 0 of 30 files reviewed, 1 unresolved discussion (waiting on CydeWeys and ptkach).


core/src/test/java/google/registry/flows/domain/DomainUpdateFlowTest.java line 992 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

Is that what we actually want to do though, or is that going to cause more customer inquiries? What's the overall migration/messaging strategy on this?

We haven't discussed the precise messaging yet, but i think it seems pretty straightforward to do the same thing we did with contact removals.

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@CydeWeys made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 30 files reviewed, all discussions resolved (waiting on ptkach).

@gbrodman
gbrodman added this pull request to the merge queue Jun 16, 2026
Merged via the queue into google:master with commit 9faabb0 Jun 16, 2026
14 of 15 checks passed
@gbrodman
gbrodman deleted the 9904algorithm branch June 16, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants