Skip to content

Add test for perm check for EPP password changes#3099

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:checkPermEppPassword
Jun 29, 2026
Merged

Add test for perm check for EPP password changes#3099
gbrodman merged 1 commit into
google:masterfrom
gbrodman:checkPermEppPassword

Conversation

@gbrodman

@gbrodman gbrodman commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@gbrodman
gbrodman force-pushed the checkPermEppPassword branch 2 times, most recently from b5c4844 to 8e33b48 Compare June 23, 2026 15:59
@gbrodman
gbrodman requested a review from ptkach June 23, 2026 20:48

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptkach reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).


core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 96 at r1 (raw file):

    }

    checkPermission(user, eppRequestBody.registrarId, ConsolePermission.EDIT_REGISTRAR_DETAILS);

I think https://github.com/google/nomulus/pull/3076/changes already checks permission

@gbrodman
gbrodman force-pushed the checkPermEppPassword branch from 8e33b48 to 0976cb5 Compare June 25, 2026 20:47
@gbrodman
gbrodman force-pushed the checkPermEppPassword branch from 0976cb5 to 1c952f6 Compare June 25, 2026 20:48
@gbrodman gbrodman changed the title Add extra perm check for EPP password changes Add test for perm check for EPP password changes Jun 25, 2026

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on ptkach).


core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 96 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

I think https://github.com/google/nomulus/pull/3076/changes already checks permission

So it did. I wasn't aware of that / it hadn't merged. But that didn't add tests (which this now does)

@ptkach ptkach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptkach reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).

@gbrodman
gbrodman added this pull request to the merge queue Jun 29, 2026
Merged via the queue into google:master with commit 9a032e4 Jun 29, 2026
15 of 16 checks passed
@gbrodman
gbrodman deleted the checkPermEppPassword branch June 29, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants