Remove class name option in GetRoutingMapCommand#3101
Conversation
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on gbrodman).
core/src/main/java/google/registry/tools/GetRoutingMapCommand.java line 28 at r1 (raw file):
System.out.println( RouterDisplayHelper.extractHumanReadableRoutesFromComponent( Class.forName("google.registry.module.RequestComponent")));
Why not just use the class object here?
Code quote:
Class.forName("google.registry.module.RequestComponent")we only have the one component now, and in general it's a good idea to remove class loading based on user input, even if that user is one of us
7aec5df to
6a11e2c
Compare
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on weiminyu).
core/src/main/java/google/registry/tools/GetRoutingMapCommand.java line 28 at r1 (raw file):
Previously, weiminyu (Weimin Yu) wrote…
Why not just use the class object here?
ugh i thought that we didn't have access to that due to project structure (thought this was in util) but it turns out we do have access!
|
not the most important PR but still, friendly ping |
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu made 1 comment and resolved 1 discussion.
Reviewable status: 2 of 4 files reviewed, all discussions resolved.
we only have the one component now, and in general it's a good idea to remove class loading based on user input, even if that user is one of us
tested on alpha
This change is