Throw on invalid responses from SafeBrowsing

[gbrodman]

this allows us to

1. use the built-in retrier to retry
2. fail loudly if it keeps actually throwing an exception if we're doing something invalid

---

This change is 

[gbrodman]

friendly ping

[jicelhay]

core/src/main/java/google/registry/beam/spec11/SafeBrowsingTransforms.java line 239 at r2 (raw file):

          new InputStreamReader(response.getEntity().getContent(), UTF_8)) {
        JSONObject responseBody = new JSONObject(CharStreams.toString(reader));
        logger.atInfo().log("Got response: %s", responseBody);

sanitize responseBody to avoid Log Injection - "This log entry depends on a user-provided value." warning.

[jicelhay]

done. I was OOO last week.

[gbrodman]

@gbrodman made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jicelhay).

---

core/src/main/java/google/registry/beam/spec11/SafeBrowsingTransforms.java line 239 at r2 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

sanitize responseBody to avoid Log Injection - "This log entry depends on a user-provided value." warning.

eh yeah let's just remove it, not needed

[jicelhay]

[jicelhay]

@jicelhay reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on gbrodman).