Don't use the cache in checking host liveness#3122
Closed
gbrodman wants to merge 1 commit into
Closed
Conversation
i think we don't generally use the EPP resource cache anyway, but just in case
weiminyu
approved these changes
Jul 1, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
Collaborator
Author
|
punting on this, if we need it in times of high load, the cache is worth the risk given that hosts are infrequently deleted |
Member
|
Explaining for posterity: I added this feature in ce136f9 , which we needed for the .app/.dev launches (and might need for future TLD launches). It's gated behind a configuration option which is currently off anyway, but we might want to turn that on again temporarily in advance of new major launches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i think we don't generally use the EPP resource cache anyway, but just in case
This change is