Join cancellations on billing time as well

[gbrodman]

This is a small edge case where a cancellation for year 2 could cancel out events in year 1 if we re-ran billing for year 1 for some reason. I don't think we would ever re-run one year later so this is kind of moot, but it's probably still a good thing to do.

---

This change is 

[jicelhay]

core/src/main/resources/google/registry/beam/billing/sql/cloud_sql_billing_events.sql line 33 at r1 (raw file):

JOIN Tld t ON t.tldStr = d.tld
LEFT JOIN BillingCancellation c ON b.id = c.billingEvent
LEFT JOIN BillingCancellation cr ON b.cancellationMatchingBillingEvent = cr.billingRecurrence AND b.billingTime = cr.billingTime

How sure are you that these billingTimes will match exactly for valid cancellations?

[gbrodman]

@gbrodman made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on jicelhay).

---

core/src/main/resources/google/registry/beam/billing/sql/cloud_sql_billing_events.sql line 33 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

How sure are you that these billingTimes will match exactly for valid cancellations?

Yep. The cancellation billing time, grace period expiration time, and BillingEvent billing time are always the same

[jicelhay]

core/src/main/resources/google/registry/beam/billing/sql/cloud_sql_billing_events.sql line 33 at r1 (raw file):

Previously, gbrodman wrote…

Yep. The cancellation billing time, grace period expiration time, and BillingEvent billing time are always the same

Alright, worth having a confirmation. LGTM.

[jicelhay]

@jicelhay reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on gbrodman).