Enforce nonnegative costs for TLDs

[gbrodman]

This change is 

[CydeWeys]

@CydeWeys made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on gbrodman).

---

core/src/main/java/google/registry/tools/ConfigureTldCommand.java line 168 at r1 (raw file):

    }
    // Enforce any builder restrictions, e.g. "no negative fees"
    newTld = newTld.asBuilder().build();

This is weird. It makes more sense to me to move all the verification to another method that you call here, and then call it from within the build() method as well.

[gbrodman]

@gbrodman made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on CydeWeys).

---

core/src/main/java/google/registry/tools/ConfigureTldCommand.java line 168 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

This is weird. It makes more sense to me to move all the verification to another method that you call here, and then call it from within the build() method as well.

Done.

[CydeWeys]

@CydeWeys made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on gbrodman).

---

core/src/main/java/google/registry/model/tld/Tld.java line 817 at r2 (raw file):

  }

  public void validateState() {

Worth adding a short Javadoc here, as this is a public method. (And also this is different from other ImmutableObjects.)

[gbrodman]

@gbrodman made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on CydeWeys).

---

core/src/main/java/google/registry/model/tld/Tld.java line 817 at r2 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

Worth adding a short Javadoc here, as this is a public method. (And also this is different from other ImmutableObjects.)

Done.

[CydeWeys]

@CydeWeys resolved 1 discussion.
Reviewable status: 0 of 6 files reviewed, all discussions resolved.

[CydeWeys]

@CydeWeys reviewed 6 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on gbrodman).