Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic search functionality #871

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

myanvoos
Copy link
Contributor

Added a basic search functionality to the main index page of the experimental reports. Currently the search criteria only includes the project's name and benchmarks if they exist, but can be expanded upon in the future.

The current implementation is client-side and responds immediately to user inputs. We can test how well it performs on larger experiment sizes and add a server-side search handler if needed.

Preview

search-preview

@DonggeLiu
Copy link
Collaborator

Thanks @myanvoos!
This basic search function is certainly a nice-to-have, but does it provide any additional functionality beyond what a browser's Ctrl+F (Cmd+F) search offers?

I understand this is an initial implementation, but to clarify expectations for other contributors:
We are looking for a search feature that can scan the contents of all pages (particularly, sample page).
For instance, it should allow searching for all trials that crashed due to a specific error.

@DonggeLiu DonggeLiu marked this pull request as draft March 17, 2025 03:50
@DonggeLiu
Copy link
Collaborator

I will mark this as a draft for now in case you'd like to extend it later : )
Please feel free to spent more time on your proposal for now, that is the key factor in evaluating your application.

@myanvoos
Copy link
Contributor Author

Thanks @myanvoos! This basic search function is certainly a nice-to-have, but does it provide any additional functionality beyond what a browser's Ctrl+F (Cmd+F) search offers?

I understand this is an initial implementation, but to clarify expectations for other contributors: We are looking for a search feature that can scan the contents of all pages (particularly, sample page). For instance, it should allow searching for all trials that crashed due to a specific error.

Thanks for the clarification @DonggeLiu! That will certainly help in the proposed design and yep, I'm happy to extend it later ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants