Skip to content

Conversation

@thesamesam
Copy link
Contributor

@thesamesam thesamesam commented Apr 18, 2024

This reverts commit ae9dd26.

There is no evidence that the LZMA SDK in 7zip was affected at all - the issue in xz was a rogue co-maintainer.

I have also fixed the copyright headers, per CI.

--

See also the discussion at #11805 (comment). I don't have an association with LZMA SDK, but noticed this when fixing up xz (for which I do have an association).

This reverts commit ae9dd26.

There is no evidence that the LZMA SDK in 7zip was affected at all - the
issue in xz was a rogue co-maintainer.

I have also fixed the copyright headers, per CI.
@thesamesam
Copy link
Contributor Author

cc @maflcko @fancycode

@thesamesam thesamesam mentioned this pull request Apr 18, 2024
@thesamesam
Copy link
Contributor Author

re #11805 (comment), we need to figure out what email to use instead.

@github-actions
Copy link

thesamesam is integrating a new project:
- Main repo: https://github.com/fancycode/lzma-fuzz.git
- Criticality score: 0.23668

homepage: "https://www.7-zip.org/sdk.html"
main_repo: 'https://github.com/fancycode/lzma-fuzz.git'
language: c++
primary_contact: "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, I used https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=41865&q=proj%3Alzma&can=1 and hovered on the "red clock" which says "Email to this user bounced". (Need to sign in to see it)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://sourceforge.net/p/sevenzip/discussion/45797/thread/7b6c966e/, Igor Pavlov wants to be contacted through sourceforge only:

Open
http://sourceforge.net/projects/sevenzip/
Click the link of developer.
And then click "Send me a message" link.

While this link doesn't seem to exist any more, at the time I created the project initally here, the [email protected] still worked as far as I can remember. I could not find any other address just now.

@jonathanmetzman
Copy link
Contributor

@fancycode Do you approve?

Copy link
Contributor

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) May 6, 2024 16:54
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman merged commit 1609420 into google:master May 6, 2024
@thesamesam thesamesam deleted the lzma-fallout branch May 6, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants