Reapply "Save docker images for C/C++" (#12876) #12937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit be6c929.
oliverchang
approved these changes
Jan 15, 2025
| args.extend(['--tag', image_name]) | ||
|
|
||
| step = { | ||
| 'name': DOCKER_TOOL_IMAGE, | ||
| 'args': args, | ||
| 'dir': directory, | ||
| 'id': f'build-{get_unique_build_step_image_id()}', |
There was a problem hiding this comment.
can you add a comment to explain what this is needed for?
There was a problem hiding this comment.
This awful bit of code (awful because the tests make it awful, because I need to change 5 or 6 3000 line golden files) is needed to allow the push step to happen concurrently with compilation.
|
/gcbrun trial_build.py c c++ --sanitizer address --fuzzing-engine libfuzzer |
|
/gcbrun trial_build.py c++ --sanitizer address --fuzzing-engine libfuzzer |
1 similar comment
|
/gcbrun trial_build.py c++ --sanitizer address --fuzzing-engine libfuzzer |
|
/gcbrun trial_build.py tinyusb pigweed --sanitizer address --fuzzing-engine libfuzzer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit be6c929.