Build OSS-Fuzz projects with FuzzBench fuzzers. #13126
Conversation
|
/gcbrun oss_fuzz_on_demand.py libaom hermes zstd --sanitizer coverage --fuzzing-engine libfuzzer |
|
/gcbrun oss_fuzz_on_demand.py skcms --sanitizer coverage --fuzzing-engine libafl |
|
/gcbrun oss_fuzz_on_demand.py skcms |
|
/gcbrun oss_fuzz_on_demand.py skcms --sanitizer coverage --fuzzing-engine libafl |
|
/gcbrun oss_fuzz_on_demand.py skcms --sanitizer coverage --fuzzing-engine libafl |
|
/gcbrun oss_fuzz_on_demand.py skcms --sanitizer coverage --fuzzing-engine mopt |
|
/gcbrun oss_fuzz_on_demand.py skcms --fuzzing-engine libafl |
|
/gcbrun oss_fuzz_on_demand.py skcms --sanitizer coverage --fuzzing-engine mopt |
|
/gcbrun oss_fuzz_on_demand.py skcms --fuzzing-engine mopt |
1 similar comment
|
/gcbrun oss_fuzz_on_demand.py skcms --fuzzing-engine mopt |
|
/gcbrun oss_fuzz_on_demand.py skcms --fuzzing-engine libafl |
|
/gcbrun oss_fuzz_on_demand.py skcms --fuzzing-engine libafl |
|
/gcbrun oss_fuzz_on_demand.py skcms --fuzzing-engine libafl |
|
/gcbrun oss_fuzz_on_demand.py skcms --fuzzing-engine eclipser |
decoNR
changed the title
I think this description would be improved if it explained why certain things were done, not just that they were done. |
| @@ -18,9 +18,14 @@ | |||
| import sys | |||
| import logging | |||
|
|
|||
| import fuzzbench, build_project | |||
There was a problem hiding this comment.
We do imports on separate lines, per the style guide.
infra/build/functions/gcb.py
Outdated
| @@ -85,7 +85,8 @@ def exec_command_from_github(pull_request_number, repo, branch): | |||
| logging.info('Command: %s.', command) | |||
|
|
|||
| if command_file == OSS_FUZZ_ON_DEMAND_COMMAND_STR.split(' ')[1]: | |||
| return oss_fuzz_on_demand.oss_fuzz_on_demand_main(command) | |||
| return True if oss_fuzz_on_demand.oss_fuzz_on_demand_main( | |||
There was a problem hiding this comment.
Change to oss_fuzz_on_demand.oss_fuzz_on_demand_main( command) == 0
| return parser.parse_args() | ||
| parser.add_argument('--fuzzing-engine', | ||
| required=False, | ||
| default='libafl', |
There was a problem hiding this comment.
This is not a good default, it should probably be libfuzzer.
|
/gcbrun oss_fuzz_on_demand.py skcms |
Use fuzzbench.py for building OSS-Fuzz projects with FuzzBench fuzzers.
fuzzbench.py'sget_build_stepsfunction in theoss_fuzz_on_demand.pymain function.FUZZ_TARGETenvironment variable value to an empty string to be able to find binary targets during the build.OUTenvironment variable overwrite onfuzzbench.pyto make code more understandable.Related to b/401215144 .