chore: ensure all text files end with a single blank newline #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
ci/enforce-end-of-file-newline
branch
4 times, most recently
from
98444eb to
7cf0568
Compare
G-Rath
changed the title
G-Rath
force-pushed
the
ci/enforce-end-of-file-newline
branch
from
7cf0568 to
0b9683d
Compare
G-Rath
force-pushed
the
ci/enforce-end-of-file-newline
branch
from
0b9683d to
acc483e
Compare
another-rex
approved these changes
Mar 18, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we have this captured with
.editorconfigwhich is supported by a lot of editors, it's very easy to miss in the review UI and in VSCode in particular requires an extension to be installed meaning people need to be aware it's a thing; so this setups up CI to explicitly check and warn about this.Unsurprisingly this has revealed a handful of files that have extraneous end-of-file newlines, most of which are in test files though I don't think they're actually critical to the test so I have removed them - the only ones I've ignored are two that are explicitly covering behaviour when there are trailing newlines, though I actually suspect it would be fine to have just a single newline at the end of the file, which would be nice at it would let us avoid needing a
.linelintconfig, but for now I've just ignored them.Relates to #455