-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few improvements for riscv #5662
A few improvements for riscv #5662
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks! For the syzkaller/dashboard/config/linux/README.md Lines 112 to 119 in 7cc1700
I.e. run And regarding |
Arf, sorry about the "Run"... Since I'm here, I noticed riscv is excluded from a few configs in files like Thanks for your quick answer! |
Overall, we try to reduce the number of enabled configs for the platforms that we run in emulation (like riscv) - the execution is very slow and we'd rather focus it on the parts more relevant to the specific platform rather than on the generic code that's already well tested elsewhere. E.g. see the Specifically in
If you believe that we'd better still fuzz some of them on the riscv syzbot instance, feel free to send a PR to switch them on or just let us know :) |
a15d19d
to
c636fa7
Compare
@a-nogikh Sorry to ping you, I'm not sure you were notified by my force-push. Or maybe you ignored it because of the ci/build failure? In that case, I would definitely need help to understand it :) Thanks |
Hi @AlexGhiti ! Regarding the CI failures -- could you please rebase your changes on top of the latest master? We recently did fix some syzkaller bugs that could have led to the failures like the ones you got. |
KASAN_INLINE was fixed back in early 2023 in the riscv kernel, see merge commit 2667e3673f70 ("Merge patch series "RISC-V kasan rework"). It happens that the riscv configuration was already using KASAN_INLINE so this is simply a cleanup. Since this is my first commit in syzkaller, I also added myself and Rivos in the AUTHORS/CONTRIBUTORS files.
Riscv is far from having a hw with a 5-level support, so let's focus on the 4-level.
kexec, memory hotplug/remove and THP features depend on architecture specific code, so let's exercise this for riscv.
c636fa7
to
67dad93
Compare
Filed #5775. |
Thanks @a-nogikh! |
Thanks for preparing the PR :) |
This reenables KASAN_INLINE and sets 4-level page table by default: note that we can use a kernel command line parameter instead if you prefer ("no5lvl").