Repository navigation
Preserve allocating thread and CPU in DeallocationProfiler. - #1835
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1013101850
branch
from
November 5, 2026 04:01
45ed1be to
67e09ec
Compare
copybara-service
Bot
changed the title
DeallocationProfiler.
copybara-service
Bot
force-pushed
the
test_1013101850
branch
3 times, most recently
from
November 5, 2026 14:24
c5baa78 to
bcb72ab
Compare
It previously attributed pre-existing live allocations seeded via DeallocationProfilerList::Add to the thread starting the profiler rather than the allocating thread. Storing cpu_id, vcpu_id, and thread_id in StackTrace preserves thread and CPU matching across seeded allocations. Co-authored-by: Chris Kennelly <ckennelly@google.com> PiperOrigin-RevId: 1014653130
copybara-service
Bot
force-pushed
the
test_1013101850
branch
from
November 5, 2026 14:36
bcb72ab to
543b267
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve allocating thread and CPU in DeallocationProfiler.
It previously attributed pre-existing live allocations seeded via
DeallocationProfilerList::Add to the thread starting the profiler rather than
the allocating thread. Storing cpu_id, vcpu_id, and thread_id in StackTrace
preserves thread and CPU matching across seeded allocations.
Co-authored-by: Chris Kennelly ckennelly@google.com