Introduce rocm-only tag and remove if_rocm_is_configured #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_673362415
branch
5 times, most recently
from
8b97c67
to
1b45fa3
Compare
This replaces all `if_rocm_is_configured` guards in `stream_executor/rocm/...` with a filtering tag `rocm-only`. The CUDA build on the CI gets adjusted to skip those targets. This uncovered some additional problems that get fixed as well: - A wrong library name for the hipfft library in the Bazel CUDA configuration - A wrong test case in the RocmVersionParser test that so far has not been running anywhere. - Missing tags for the platform alias targets in `stream_executor/BUILD` PiperOrigin-RevId: 678548961
copybara-service
bot
force-pushed
the
test_673362415
branch
from
1b45fa3
to
e7dc77f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce rocm-only tag and remove if_rocm_is_configured
This replaces all
if_rocm_is_configuredguards instream_executor/rocm/...with a filtering tagrocm-only. The CUDA build on the CI gets adjusted to skip those targets.This uncovered some additional problems that get fixed as well:
stream_executor/BUILD