Add CVE-2022-26148 Detector Plugin #581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1ktor0t
suggested changes
Dec 31, 2024
There was a problem hiding this comment.
Hello @just-hms, thank you for your contribution!
Overall, the plugin is well designed as works as intended. I added some suggestions to clean up the description and some improvements on the supplied unit tests.
Let me know if you have any questions.
doyensec/detectors/grafana_zabbix_credential_disclosure/README.md
Outdated
Show resolved
Hide resolved
.../detectors/cve/cve202226148/CredentialsDisclosureInGrafanaZabbixIntegrationDetectorTest.java
Show resolved
Hide resolved
doyensec/detectors/grafana_zabbix_credential_disclosure/README.md
Outdated
Show resolved
Hide resolved
doyensec/detectors/grafana_zabbix_credential_disclosure/README.md
Outdated
Show resolved
Hide resolved
doyensec/detectors/grafana_zabbix_credential_disclosure/README.md
Outdated
Show resolved
Hide resolved
|
Hi @v1ktor0t , thanks for your suggestions, I’ve updated the README as recommended and left a comment on the unit test #581 (comment) , let me know your thoughts. |
add: check the number of executed requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR contains the implementation for the CVE-2022-26148 detector.
Below it is possible to find the necessary information for review:
Thank you.