New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make `ProcessOutput` iterable #1101

Merged

antongolub merged 2 commits into google:main from antongolub:iterable-process-output

Feb 17, 2025

Collaborator

antongolub commented Feb 17, 2025 •

edited

Loading

closes #1053
closes #1027

supersedes #1088
relates #984

const o = new ProcessOutput({
  store: {
    stdall: ['foo\nba', 'r\nbaz'],
  },
})
const lines = []
const expected = ['foo', 'bar', 'baz']
for (const line of o) {
  lines.push(line)
}
assert.deepEqual(lines, expected)
assert.deepEqual(o.lines(), expected)

Tests pass
Appropriate changes to README are included in PR

antongolub added 2 commits

February 17, 2025 22:05


          feat: make ProcessOutput iterable

75a620f

closes google#1053
closes google#1027

relates google#1088
relates google#984


          refactor: reuse iterators logic

53b3bab

antongolub requested a review from antonmedv

February 17, 2025 19:50

antongolub merged commit 1fc9d0b into google:main

24 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet