Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an example program linking OpenCensus with Bazel #958

Closed
coryan opened this issue Aug 1, 2018 · 1 comment · Fixed by #1230
Closed

Create an example program linking OpenCensus with Bazel #958

coryan opened this issue Aug 1, 2018 · 1 comment · Fixed by #1230
Assignees
@manish-qlogic
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Cloud Bigtable: GA

Comments

@coryan
Copy link
Contributor

coryan commented Aug 1, 2018

Create a program, with its own WORKSPACE that links OpenCensus and google-cloud-cpp. In this version we should just link with Bazel, since OpenCensus does not support CMake yet (see census-instrumentation/opencensus-cpp#86).

This depends on #957.
@coryan coryan added api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 1, 2018
@coryan coryan added this to the Cloud Bigtable: 1.0 release milestone Aug 1, 2018
@coryan coryan mentioned this issue Aug 1, 2018
Closed
@manish-qlogic manish-qlogic self-assigned this Aug 31, 2018
@manish-qlogic
Copy link
Contributor

@coryan

as per the link, subdirectories can be excluded using '-'.

To check this, I have created a sub-project opencensus inside //google/cloud/bigtable/example with its own BUILD and WORKSPACE.
The command bazel --batch build -- "//google/cloud/...:all" -"//google/cloud/bigtable/examples/opencensus/... does excludes the opencensus folder.

Now, I will create an example and link both bigtable_client and opencensus in the subproject.

@manish-qlogic manish-qlogic mentioned this issue Oct 9, 2018
Merged
coryan pushed a commit that referenced this issue Oct 24, 2018
@manish-qlogic @coryan
Bazel build for opencensus bigtable integration (#1230)
a35af16 
This fixes #958. It provides an example on how to use OpenCensus with the Cloud Bigtable C++ client library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manish-qlogic manish-qlogic

Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Cloud Bigtable: GA
Development

Successfully merging a pull request may close this issue.

Bazel build for opencensus bigtable integration manish-qlogic/google-cloud-cpp
2 participants
@coryan @manish-qlogic