impl(bigtable): make endpoint options internal

[mpeddada1]

Fixes #9081

[gemini-code-assist]

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Bigtable client library by relocating specific endpoint option definitions to an internal header. This change centralizes the management of these options within the library's internal implementation, aligning with the deprecation of these specific options in favor of a more general google::cloud::EndpointOption for external use.

Highlights

• Endpoint Option Internalization: Moved DataEndpointOption, AdminEndpointOption, and InstanceAdminEndpointOption definitions from google/cloud/bigtable/options.h to a new internal header google/cloud/bigtable/internal/endpoint_options.h.
• Build System Updates: Updated CMakeLists.txt and google_cloud_cpp_bigtable.bzl to include the newly created internal header.
• API Reference Update: Modified ClientOptionList in options.h to refer to the internal versions of the endpoint options, ensuring continued functionality while enforcing their internal status.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors deprecated endpoint options into an internal namespace, which is a good improvement. However, I've found a couple of issues that need to be addressed. A circular header dependency is introduced, and there's an incorrect namespace usage that will cause a compilation failure. I've provided specific comments and suggestions to resolve these problems.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (5cd5046) to head (f839914).
⚠️ Report is 1 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15856      +/-   ##
======================================================
- Coverage               92.89%   92.88%   -0.01%     
======================================================
  Files                    2398     2398              
  Lines                  218492   218531      +39     
======================================================
+ Hits                   202961   202987      +26     
- Misses                  15531    15544      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.