-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bigtable): Track number of rows read to set rowsLimit in subsequent requests #10213
Open
bhshkh
wants to merge
11
commits into
googleapis:main
Choose a base branch
from
bhshkh:test/cbt-proxy-rowslimit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
Issues related to the Bigtable API.
label
May 16, 2024
@bhshkh is this still wanted/needed? |
bhshkh
changed the title
test(bigtable):
test(bigtable): Fix conformance test TestReadRows_NoRetry_ErrorAfterLastRow
Dec 11, 2024
Yes |
mutianf
reviewed
Dec 11, 2024
bhshkh
changed the title
test(bigtable): Fix conformance test TestReadRows_NoRetry_ErrorAfterLastRow
fix(bigtable): Track number of readrows to set rowsLimit in subsequent requests
Jan 13, 2025
mutianf
reviewed
Jan 14, 2025
bhshkh
changed the title
fix(bigtable): Track number of readrows to set rowsLimit in subsequent requests
fix(bigtable): Track number of rows read to set rowsLimit in subsequent requests
Jan 15, 2025
andre-sampaio
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking bug: b/303943537
This PR fixes TestReadRows_NoRetry_ErrorAfterLastRow test
https://github.com/googleapis/cloud-bigtable-clients-test/blob/db4d6a9e8e5e38b6f07383bd46ac14bfc8d8b9b6/tests/readrows_test.go#L171-L173
fails with error:
The test sends below request to Go Bigtable proxy:
On receiving the request, the proxy creates a ReadRows request for the client library and invokes ReadRows function.
Even though test sends RowsLimit field in the method, the proxy does not add it to the client library request. This has been fixed in this PR.