Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): Track number of rows read to set rowsLimit in subsequent requests #10213

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented May 16, 2024

Tracking bug: b/303943537

This PR fixes TestReadRows_NoRetry_ErrorAfterLastRow test

https://github.com/googleapis/cloud-bigtable-clients-test/blob/db4d6a9e8e5e38b6f07383bd46ac14bfc8d8b9b6/tests/readrows_test.go#L171-L173

fails with error:

--- FAIL: TestReadRows_NoRetry_ErrorAfterLastRow (0.03s)
    readrows_test.go:201: 
        	Error Trace:	cloud-bigtable-clients-test/tests/readrows_test.go:201
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestReadRows_NoRetry_ErrorAfterLastRow
--- FAIL: TestReadRows_Retry_LastScannedRow_Reverse (0.04s)

The test sends below request to Go Bigtable proxy:

Request: &btpb.ReadRowsRequest{
	TableName: buildTableName("table"),
	RowsLimit: 1,
},

On receiving the request, the proxy creates a ReadRows request for the client library and invokes ReadRows function.
Even though test sends RowsLimit field in the method, the proxy does not add it to the client library request. This has been fixed in this PR.

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 16, 2024
@codyoss
Copy link
Member

codyoss commented Dec 10, 2024

@bhshkh is this still wanted/needed?

@bhshkh bhshkh changed the title test(bigtable): test(bigtable): Fix conformance test TestReadRows_NoRetry_ErrorAfterLastRow Dec 11, 2024
@bhshkh
Copy link
Contributor Author

bhshkh commented Dec 11, 2024

@bhshkh is this still wanted/needed?

Yes

@bhshkh bhshkh marked this pull request as ready for review December 11, 2024 19:32
@bhshkh bhshkh requested review from a team as code owners December 11, 2024 19:32
@bhshkh bhshkh changed the title test(bigtable): Fix conformance test TestReadRows_NoRetry_ErrorAfterLastRow fix(bigtable): Track number of readrows to set rowsLimit in subsequent requests Jan 13, 2025
@bhshkh bhshkh requested review from mutianf and gkevinzheng January 13, 2025 22:23
bigtable/bigtable.go Show resolved Hide resolved
bigtable/bigtable.go Outdated Show resolved Hide resolved
bigtable/bigtable.go Show resolved Hide resolved
bigtable/bigtable.go Show resolved Hide resolved
bigtable/bigtable.go Show resolved Hide resolved
@bhshkh bhshkh enabled auto-merge (squash) January 15, 2025 20:13
@bhshkh bhshkh changed the title fix(bigtable): Track number of readrows to set rowsLimit in subsequent requests fix(bigtable): Track number of rows read to set rowsLimit in subsequent requests Jan 15, 2025
@bhshkh bhshkh requested a review from andre-sampaio January 15, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants