Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update remaining usages of Go 1.21 to 1.22 #11378

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

fasmat
Copy link
Contributor

@fasmat fasmat commented Jan 7, 2025

I found a few places in the codebase where Go 1.21 is still used after support for it has officially been dropped. This updates those to Go 1.22.

@fasmat fasmat requested review from a team as code owners January 7, 2025 09:57
@fasmat fasmat force-pushed the chore-clean-go-1.21-residuals branch from 3576af8 to 08e5e7d Compare January 7, 2025 09:59
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
@fasmat
Copy link
Contributor Author

fasmat commented Jan 7, 2025

@codyoss sorry, its seems I have overlooked one use of an older Go version in vet.sh and fixed it in my lastest commit 🙂

@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
@codyoss
Copy link
Member

codyoss commented Jan 7, 2025

Kicked off CI again. I would not be surprised if more pops up by increasing the staticcheck version. If so, we may want to file a bug for that and bump that separately. Thanks for the contribution!

@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
@codyoss codyoss added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jan 7, 2025
@codyoss codyoss merged commit 16e4068 into googleapis:main Jan 7, 2025
10 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jan 7, 2025
@codyoss
Copy link
Member

codyoss commented Jan 7, 2025

Thanks again!

@fasmat fasmat deleted the chore-clean-go-1.21-residuals branch January 7, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants