feat(bigtable): attach client config UUID header to GetClientConfigur… - #13972
feat(bigtable): attach client config UUID header to GetClientConfigur…#13972mutianf wants to merge 1 commit into
Conversation
…ationRequest Generate a UUID when the session client is initialized and attach it via the bigtable-client-config-uuid header on every GetClientConfigurationRequest (the initial fetch and all refresh polls) so the server can correlate requests from the same client instance.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a unique client UUID header (bigtable-client-config-uuid) to ClientConfigurationManager that is attached to all GetClientConfigurationRequest calls (both initial and refresh requests) to allow the server to correlate requests from the same client. It also adds a unit test to verify this behavior. The reviewer suggested adding a timeout to the get() call on the future in the test to prevent potential indefinite hangs.
| assertThat(ClientConfigurationManager.CLIENT_UUID_KEY.name()).startsWith("bigtable-"); | ||
|
|
||
| // Fetch the initial config and capture the header sent with it. | ||
| manager.start().get(); |
There was a problem hiding this comment.
Using an unbounded get() on a Future in tests can cause the test suite to hang indefinitely if the future never completes (e.g., due to a deadlock or a bug in the production code). It is highly recommended to specify a timeout, such as get(10, java.util.concurrent.TimeUnit.SECONDS), to ensure the test fails fast and provides a clear error message.
| manager.start().get(); | |
| manager.start().get(10, java.util.concurrent.TimeUnit.SECONDS); |
There was a problem hiding this comment.
Code Review
This pull request introduces a unique client session identifier (UUID) in ClientConfigurationManager that is attached as a gRPC metadata header (bigtable-client-config-uuid) to all initial and refresh configuration requests. This allows the server to correlate requests originating from the same client instance. Corresponding unit tests have been added to verify that the UUID is correctly generated and sent with both initial and refresh requests. There are no review comments, and we have no feedback to provide.
|
Will wrap it in a proto and send it for all requests. |
1 participant
…ationRequest
Generate a UUID when the session client is initialized and attach it via the bigtable-client-config-uuid header on every GetClientConfigurationRequest (the initial fetch and all refresh polls) so the server can correlate requests from the same client instance.