Skip to content

refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it - #13988

Draft
jinseopkim0 wants to merge 2 commits into
mainfrom
create-bigquerystorage-it-module
Draft

refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it#13988
jinseopkim0 wants to merge 2 commits into
mainfrom
create-bigquerystorage-it-module

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

Moves all 22 integration test classes and helper/proto resources from google-cloud-bigquerystorage into a dedicated downstream integration test module (google-cloud-bigquerystorage-it).

Motivation

  • Removes the test-scope dependency on google-cloud-bigquery from google-cloud-bigquerystorage.
  • Prevents test code and .proto schema duplication between java-bigquery and java-bigquerystorage.
  • Consolidates all end-to-end integration tests in a dedicated downstream module that depends on both google-cloud-bigquerystorage and google-cloud-bigquery.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new integration testing module, google-cloud-bigquerystorage-it, and moves the google-cloud-bigquery test dependency from the main storage module to this new integration test module. The feedback suggests managing the avro dependency version in the parent POM's <dependencyManagement> section rather than hardcoding it in the child module's pom.xml to ensure consistency.

Comment on lines +29 to +34
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
<version>1.11.4</version>
<scope>test</scope>
</dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Avoid hardcoding dependency versions in child modules. To maintain consistency and simplify version upgrades, manage the version of avro in the parent POM's <dependencyManagement> section and omit the <version> tag here.

    <dependency>
      <groupId>org.apache.avro</groupId>
      <artifactId>avro</artifactId>
      <scope>test</scope>
    </dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant