refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it - #13988
Draft
jinseopkim0 wants to merge 2 commits into
Draft
refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it#13988jinseopkim0 wants to merge 2 commits into
jinseopkim0 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration testing module, google-cloud-bigquerystorage-it, and moves the google-cloud-bigquery test dependency from the main storage module to this new integration test module. The feedback suggests managing the avro dependency version in the parent POM's <dependencyManagement> section rather than hardcoding it in the child module's pom.xml to ensure consistency.
Comment on lines
+29
to
+34
| <dependency> | ||
| <groupId>org.apache.avro</groupId> | ||
| <artifactId>avro</artifactId> | ||
| <version>1.11.4</version> | ||
| <scope>test</scope> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
Avoid hardcoding dependency versions in child modules. To maintain consistency and simplify version upgrades, manage the version of avro in the parent POM's <dependencyManagement> section and omit the <version> tag here.
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
<scope>test</scope>
</dependency>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all 22 integration test classes and helper/proto resources from
google-cloud-bigquerystorageinto a dedicated downstream integration test module (google-cloud-bigquerystorage-it).Motivation
google-cloud-bigqueryfromgoogle-cloud-bigquerystorage..protoschema duplication betweenjava-bigqueryandjava-bigquerystorage.google-cloud-bigquerystorageandgoogle-cloud-bigquery.