feat(bigquery): add ArrowQueryPageFetcher for Arrow query result pagination - #14404
Open
jinseopkim0 wants to merge 3 commits into
Open
jinseopkim0 wants to merge 3 commits into
jinseopkim0 wants to merge 3 commits into
Conversation
jinseopkim0
added this pull request to stack #14406
September 16, 2026 17:04
jinseopkim0
marked this pull request as ready for review
September 16, 2026 17:05
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ArrowQueryPageFetcher static class in BigQueryImpl.java to handle pagination for queries returning results in Arrow format by reading from the default gRPC storage read stream. It also updates configureReadSettings to use NoHeaderProvider as a default and adds a comprehensive suite of unit tests in ArrowQueryPageFetcherTest.java to verify the fetcher's behavior, including pagination, limit enforcement, error handling, and serialization. There are no review comments, so no additional feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
ArrowQueryPageFetcherto handle pagination for queries executing withQueryResultsFormat.ARROW.Summary of Changes
ArrowQueryPageFetcherimplementingNextPageFetcher<FieldValueList>.ArrowDeserializer.loadArrowRowsto deserialize Arrow record batches intoFieldValueListcollections with offset andmaxResultsbounding.ArrowQueryPageFetcherTestcovering single-page, multi-page, max-results, and serialization behaviors.