fix(gapic-generator): restrict package discovery to gapic* namespace - #18030
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package discovery in setup.py to use an explicit inclusion pattern (gapic*) instead of excluding specific directories. The reviewer recommends refining this pattern to ["gapic", "gapic.*"] to prevent accidentally matching unrelated directories or virtual environments starting with gapic.
ohmayr
force-pushed
the
fix-gapic-generator-namespace-discovery
branch
2 times, most recently
from
August 7, 2026 21:06
062f900 to
fe7cfee
Compare
ohmayr
force-pushed
the
fix-gapic-generator-namespace-discovery
branch
from
August 7, 2026 21:07
fe7cfee to
0f233c1
Compare
daniel-sanche
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
setup.pycalledsetuptools.find_namespace_packages(exclude=["docs", "tests"])without wildcard glob patterns.When CI (
run_single_test.sh) or local test runners created temporary virtual environments (such as.venv-profileror.nox),setuptoolsmistook those hidden directories for library packages and attempted to package their contents, causingpip install -e .and CI profiling jobs to fail or take too long.Fix
This PR updates
excludeinsetup.pyto use wildcard glob patterns: