chore: use all valid dependency envars in core_deps checks - #18392
Open
daniel-sanche wants to merge 2 commits into
Open
daniel-sanche wants to merge 2 commits into
daniel-sanche wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the noxfile.py.j2 template and its generated golden files to include UNIT_TEST_DEPENDENCIES when installing dependencies for the unit test environment in both the prerelease_deps and core_deps_from_source sessions. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UNIT_TEST_EXTERNAL_DEPENDENCIESwas deprecated in favor ofUNIT_TEST_DEPENDENCIES, but this change never made its way toprerelease_depsorcore_deps_from_sourceThis PR makes those tests check both env vars when installing dependencies
This was relevant in the firestore error in https://github.com/googleapis/google-cloud-python/actions/runs/35047678776