Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firestore): Add firestore_query_filter_compound_multi_ineq to samples #27361

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aandreassa
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Sep 25, 2024
@aandreassa aandreassa changed the title chore(firestore): Add firestore_query_filter_compound_multi_ineq to s… chore(firestore): Add firestore_query_filter_compound_multi_ineq to samples Sep 25, 2024
@aandreassa aandreassa marked this pull request as ready for review September 25, 2024 19:56
Copy link

snippet-bot bot commented Sep 25, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2024

firestore = Google::Cloud::Firestore.new project_id: project_id
cities_ref = firestore.col collection_path
# [START firestore_query_filter_compound_multi_ineq]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other samples below include the setting of cities_ref within the sample's START..END block. Are you sure this one shouldn't include it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will test it. Samples above this point have cities_ref outside, and below have it inside.

@aandreassa aandreassa force-pushed the samples-firestore-multi-ineq branch from d81314f to cd07fbc Compare December 19, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants