perf: only decode bytes to frame for query, execute and batch messages - #163
Merged
Conversation
ShuranZhang
force-pushed
the
optimize-codec
branch
from
July 18, 2025 17:50
dea9a04 to
090978e
Compare
ShuranZhang
changed the title
mayurkale22
reviewed
Jul 18, 2025
mayurkale22
previously approved these changes
Jul 18, 2025
Collaborator
|
@ath-08 Please review and submit once looks good |
ath-08
reviewed
Jul 30, 2025
ath-08
reviewed
Jul 30, 2025
ath-08
reviewed
Jul 30, 2025
ath-08
reviewed
Jul 30, 2025
ShuranZhang
force-pushed
the
optimize-codec
branch
from
July 30, 2025 21:46
1a12b7b to
d58f336
Compare
ath-08
reviewed
Jul 30, 2025
ShuranZhang
force-pushed
the
optimize-codec
branch
from
July 30, 2025 23:49
b1af72e to
ddd148f
Compare
ath-08
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip decoding bytes buffer to frame for unneeded message types.
We still decode entire frame for QUERY, EXECUTE and BATCH for now. Manually decoding is different due to custom payload flag unless we implement a complete set of custom message codec in this repo.